Scripts Refactor #296
Merged
Scripts Refactor #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refactor # Conflicts: # scripts/src/build/modules/tab.ts # yarn.lock
RichDom2185
reviewed
Mar 21, 2024
|
With the new flat configurations that ESLint is moving towards, I basically redid the ESLint setup for the repository. It should be far less janky than the way it had been setup previously and should play nicely with the VSCode extension (if you use the defaults provided in the .vscode folder) |
RichDom2185
requested changes
Mar 25, 2024
src/bundles/arcade_2d/gameobject.ts
Outdated
| @@ -1,6 +1,7 @@ | |||
| /** | |||
| * This file contains the bundle's representation of GameObjects. | |||
| */ | |||
| import Phaser from 'phaser'; | |||
There was a problem hiding this comment.
I'm trying to find where this import is used but I can't find it (and yet VSCode shows that it is not an unused import)
There was a problem hiding this comment.
I am confused by this one to be honest
…modules into scripts-refactor
|
The current sourceacademy.org frontend needs this PR to run modules. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first rewriting of the module scripts left a lot to be desired. With the benefit of new packages and lots of hindsight, here is a streamlined set of scripts that should resolve the issues where linting errors were not being properly caught by the CI.
Currently there's a really weird bug that continues to escape me with the testing for the json command, so I have that disabled. It's not really too important this instant, but it would be nice to figure out why Jest isn't calling the mocked function.
This refactor also includes some changes to how modules are loaded and how the JSON documentation is stored. I'll have the corresponding PRs in
js-slangup.