-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts Refactor #296
Scripts Refactor #296
Conversation
…refactor # Conflicts: # scripts/src/build/modules/tab.ts # yarn.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just did a quick run through – perhaps we can add "newline at EOF" as an error rule in .eslintrc.base.cjs
?
With the new flat configurations that ESLint is moving towards, I basically redid the ESLint setup for the repository. It should be far less janky than the way it had been setup previously and should play nicely with the VSCode extension (if you use the defaults provided in the .vscode folder) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semicolons are still not checked (some files have them, some files don't, and some have a mix)
src/bundles/arcade_2d/gameobject.ts
Outdated
@@ -1,6 +1,7 @@ | |||
/** | |||
* This file contains the bundle's representation of GameObjects. | |||
*/ | |||
import Phaser from 'phaser'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to find where this import is used but I can't find it (and yet VSCode shows that it is not an unused import)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused by this one to be honest
…modules into scripts-refactor
The current sourceacademy.org frontend needs this PR to run modules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
The first rewriting of the module scripts left a lot to be desired. With the benefit of new packages and lots of hindsight, here is a streamlined set of scripts that should resolve the issues where linting errors were not being properly caught by the CI.
Currently there's a really weird bug that continues to escape me with the testing for the json command, so I have that disabled. It's not really too important this instant, but it would be nice to figure out why Jest isn't calling the mocked function.
This refactor also includes some changes to how modules are loaded and how the JSON documentation is stored. I'll have the corresponding PRs in
js-slang
up.